feat(seer): Seer Code Review Overview section#111593
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| label={t('Enable Code Review by Default')} | ||
| hintText={t( | ||
| 'For all new projects, select which coding agent Seer will hand off to when processing issues.' | ||
| )} |
There was a problem hiding this comment.
Wrong hint text on code review toggle
Medium Severity
The hintText for the "Enable Code Review by Default" toggle says "For all new projects, select which coding agent Seer will hand off to when processing issues." This is unrelated copy — it describes coding agent handoff for projects, not code review for repos. The old version of this same toggle correctly said "For all new repos connected, Seer will review your PRs and flag potential bugs."
| integration.provider.features.includes('commits') | ||
| ); | ||
| const seerIntegrations = scmIntegrations.filter(integration => | ||
| isSupportedAutofixProvider({ |
There was a problem hiding this comment.
I think my PR removed this and makes it more complicated when we need to call it in a loop. you have to import isSeerSupported... and the hook that returns supportedProviderIds.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unconditional hook fetches data behind feature flag
- Added enabled parameter to useCodeReviewOverviewSection hook that is passed to useInfiniteQuery, preventing unnecessary API calls when the seer-overview feature flag is disabled.
Or push these changes by commenting:
@cursor push b780bc1936
Preview (b780bc1936)
diff --git a/static/app/views/settings/seer/overview/codeReviewOverviewSection.tsx b/static/app/views/settings/seer/overview/codeReviewOverviewSection.tsx
--- a/static/app/views/settings/seer/overview/codeReviewOverviewSection.tsx
+++ b/static/app/views/settings/seer/overview/codeReviewOverviewSection.tsx
@@ -24,7 +24,7 @@
import {fetchMutation} from 'sentry/utils/queryClient';
import {useOrganization} from 'sentry/utils/useOrganization';
-export function useCodeReviewOverviewSection() {
+export function useCodeReviewOverviewSection(enabled = true) {
const organization = useOrganization();
const queryOptions = organizationRepositoriesInfiniteOptions({
@@ -33,6 +33,7 @@
});
const repositoriesResult = useInfiniteQuery({
...queryOptions,
+ enabled,
select: ({pages}) => {
const repos = uniqBy(
pages.flatMap(page => page.json),
diff --git a/static/gsApp/views/seerAutomation/settings.tsx b/static/gsApp/views/seerAutomation/settings.tsx
--- a/static/gsApp/views/seerAutomation/settings.tsx
+++ b/static/gsApp/views/seerAutomation/settings.tsx
@@ -44,7 +44,7 @@
const showSeerOverview = organization.features.includes('seer-overview');
const scmOverviewData = useSCMOverviewSection();
- const codeReviewOverviewData = useCodeReviewOverviewSection();
+ const codeReviewOverviewData = useCodeReviewOverviewSection(showSeerOverview);
const orgEndpoint = `/organizations/${organization.slug}/`;
const orgMutationOpts = mutationOptions({This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
2 participants
Bring in the Seer Code-Review overview section behind the
seer-overviewfeature flag.And some stories to show the different states, mostly counts of things